Remove evals from pattern-matching spec #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some evals remain for SyntaxError tests that would not parse in the main script. Most of this was done using automated tools so a few irrelevant formatting changes may have crept in. Fixes ruby#1152
headius
force-pushed
the
remove_pattern_evals
branch
2 times, most recently
from
a393b65
to
35d60c8
Compare
headius
force-pushed
the
remove_pattern_evals
branch
from
90a0c1c
to
34f0db2
Compare
headius
force-pushed
the
remove_pattern_evals
branch
2 times, most recently
from
de14b8b
to
567a79c
Compare
|
Rubocop had to be bumped to 3.1 to support the newer pattern syntax. Bumping to 3.3 brought out a bunch of issues with requires like 'fiber' and 'set' that are no longer needed. |
|
Thank you, it looks great. We could have kept the 3.1 stuff in eval's (would address RuboCop and not need a separate file), but anyway I guess we'll make ruby/spec 3.1+ soon since 3.0 is EOL now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some evals remain for SyntaxError tests that would not parse in the main script.
Most of this was done using automated tools so a few irrelevant formatting changes may have crept in.
Fixes #1152