Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rp2040-hal version 0.9.0 & bump version to 0.7.0 #28

Merged
merged 11 commits into from
Sep 1, 2023
Merged

Conversation

jannic
Copy link
Member

@jannic jannic commented Sep 1, 2023

No description provided.

@jannic jannic changed the title Use rp2040-hal version 0.9.0 Use rp2040-hal version 0.9.0 & bump version to 0.7.0 Sep 1, 2023
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question, otherwise looks good to me.

pio = "0.2.0"
smart-leds-trait = "0.2.1"
nb = "1.0.0"
cortex-m = "0.7.3"

[patch.crates-io]
rp2040-hal = { git = "https://github.com/ithinuel/rp-hal" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to keep the patch on main ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely don't need it. It doesn't even apply when using ws2812-pio as a dependency.
But is it useful? Perhaps for CI? Probably not. I'll remove it.

@jannic jannic merged commit 944494c into main Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants