Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CountDown generic support #27

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix CountDown generic support #27

merged 1 commit into from
Sep 1, 2023

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented Aug 31, 2023 •
edited
Loading

I don't know why I broke it like this when I migrated from embedded-time to fugit 🤷

@ithinuel ithinuel mentioned this pull request Aug 31, 2023
Draft
@ithinuel ithinuel changed the base branch from main to hal-0.9 August 31, 2023 09:21
jannic
jannic approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@jannic jannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't try it yet, but I'll do together with the hal-0.9 branch before merging it into main.

@jannic jannic merged commit e184292 into rp-rs:hal-0.9 Sep 1, 2023
2 checks passed
@jannic
Copy link
Member

jannic commented Sep 1, 2023

It caused a clippy warning. I fixed it directly on the hal-0.9 branch: b38b344

@ithinuel ithinuel deleted the fix-delay-support branch September 1, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannic jannic jannic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinuel @jannic