Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 version bump and changelog update #135

Merged
merged 1 commit into from
Jun 19, 2023
Merged

v1.0.1 version bump and changelog update #135

merged 1 commit into from
Jun 19, 2023

Conversation

ross
Copy link
Owner

@ross ross commented Jun 19, 2023

v1.0.1 - 2023-06-19 - The first one in the CHANGELOG

  • Add pytest.mark.network to test cases
  • pyproject.toml config for black, isort, and pytest

@ross ross self-assigned this Jun 19, 2023
@ross ross merged commit e75044d into main Jun 19, 2023
5 checks passed
@ross ross deleted the rel-1-0-1 branch June 19, 2023 19:57
@ross
Copy link
Owner Author

ross commented Jun 19, 2023

@ross
Copy link
Owner Author

ross commented Jun 19, 2023

/cc @kloczek probably useful

@kloczek
Copy link

kloczek commented Jun 19, 2023

If may I ask to remember about yet another small thing.
Is it possible next time on release new version make the github release to have entry on https://github.com/john-kurkowski/tldextract/releases? 🤔

I'm asking because only on make gh release is spread notification about new release to those who have set watch->releases.

@ross
Copy link
Owner Author

ross commented Jun 19, 2023

Is it possible next time on release new version make the github release to have entry on https://github.com/john-kurkowski/tldextract/releases? 🤔

Not sure what that repo has to do with requests-futures, but it looks like it's doing the same release tagging as I am here, https://github.com/john-kurkowski/tldextract/tags

Haven't looked into uploading actual release artifacts to github since pypi is the standard/meaningful place for python modules. https://pypi.org/project/requests-futures/#history. Seems kind of annoying to have to push the release to github just to get the notifications. It looks like pypi has the ability to do release notifications https://pypi.org/help/#project-release-notifications and supports RSS feeds as well (both links off the history page above.)

@kloczek
Copy link

kloczek commented Jun 19, 2023

Not sure what that repo has to do with requests-futures, but it looks like it's doing the same release tagging as I am here, https://github.com/john-kurkowski/tldextract/tags

It is different thing.
Please have a look on https://github.com/john-kurkowski/tldextract/releases
That tab is empty.

@ross
Copy link
Owner Author

ross commented Jun 19, 2023

It is different thing.
Please have a look on https://github.com/john-kurkowski/tldextract/releases
That tab is empty.

When I follow that link the page is empty/there are no releases. That package, whatever it is, is not using github releases.

Screen Shot 2023-06-19 at 2 32 06 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants