Upgrade node and yarn versions #828
Open
+1,362
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerezIgnacio
force-pushed
the
node-yarn-upgrade
branch
from
6c51d9d
to
1cb28b4
Compare
PerezIgnacio
requested review from
santib,
axelpontetto,
andresg4,
JulianPasquale and
a team
santib
reviewed
Sep 3, 2024
santib
reviewed
Sep 3, 2024
| @@ -1,310 +1,1330 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
we went from ~300LOC to ~1600LOC 🤯
I see new dependencies, that I guess aren't needed?
is it because of "packageManager": "[email protected]", ?
There was a problem hiding this comment.
yes, it seems to be adding some dev dependencies, not sure exactly why yet
PerezIgnacio
force-pushed
the
node-yarn-upgrade
branch
from
1cb28b4
to
ae7889b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board:
Description:
Notes:
Tasks:
Risk:
Preview: