Update to Rails 7.2 #815
Merged
Update to Rails 7.2 #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santib
approved these changes
Aug 23, 2024
enzofab91
approved these changes
Aug 23, 2024
Comment on lines
+35
to
+38
| # puts "\n== Configuring puma-dev ==" | ||
| # system "ln -nfs #{APP_ROOT} ~/.puma-dev/#{APP_NAME}" | ||
| # system "curl -Is https://#{APP_NAME}.test/up | head -n 1" | ||
|
|
There was a problem hiding this comment.
The generator adds this already commented so I left it, I don't know if we're going to use this in the future or not. Maybe we can remove it yes
There was a problem hiding this comment.
It's fine for me to leave it
juanmferreira93
approved these changes
Aug 23, 2024
JulianPasquale
approved these changes
Aug 26, 2024
|
@andresg4 feel free to merge |
andresg4
force-pushed
the
update-to-rails-7.2
branch
from
d7b2a2e
to
60011cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board:
Description:
devise_token_authorigin because the published gem doesn't support Rails 7.2 version, but in main branch it is supportedNotes:
Tasks:
Risk:
Preview: