-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag support using Flipper #387
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d47951f
Add feature flag support using Flipper
mrodriguez90 e18f310
Set gem versions, use devise authenticate instead of a constraint
mrodriguez90 d7a52cf
Add feature_flags_spec.rb
mrodriguez90 a20e2be
Fix rubocop issue
mrodriguez90 c7c5e63
Remove flipper include in user model
mrodriguez90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
class CreateFlipperTables < ActiveRecord::Migration[7.0] | ||
def self.up | ||
create_table :flipper_features do |t| | ||
t.string :key, null: false | ||
t.timestamps null: false | ||
end | ||
add_index :flipper_features, :key, unique: true | ||
|
||
create_table :flipper_gates do |t| | ||
t.string :feature_key, null: false | ||
t.string :key, null: false | ||
t.string :value | ||
t.timestamps null: false | ||
end | ||
add_index :flipper_gates, %i[feature_key key value], unique: true | ||
end | ||
|
||
def self.down | ||
santib marked this conversation as resolved.
Show resolved
Hide resolved
|
||
drop_table :flipper_gates | ||
drop_table :flipper_features | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ | |
RSpec.configure do |config| | ||
config.render_views = true | ||
config.include Devise::Test::ControllerHelpers, type: :controller | ||
config.include Devise::Test::IntegrationHelpers, type: :request | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adds devise helpers like |
||
config.include ActiveJob::TestHelper | ||
config.use_transactional_fixtures = true | ||
config.infer_spec_type_from_file_location! | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
describe 'GET admin/feature-flags', type: :request do | ||
subject { get '/admin/feature-flags' } | ||
|
||
context 'with an admin_user account' do | ||
let(:user) { create :admin_user } | ||
|
||
context 'with a valid session' do | ||
before { sign_in user } | ||
|
||
it 'shows the feature flags page' do | ||
is_expected.to redirect_to('/admin/feature-flags/features') | ||
end | ||
end | ||
|
||
context 'without a valid session' do | ||
it 'redirects the user to the admin login page' do | ||
is_expected.to redirect_to('/admin/login') | ||
end | ||
end | ||
end | ||
|
||
context 'with a user account' do | ||
let(:user) { create :user } | ||
|
||
context 'with a valid session' do | ||
before { sign_in user } | ||
|
||
it 'blocks user access to the feature flags page' do | ||
is_expected.not_to redirect_to('/admin/feature-flags/features') | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this adds the feature flag menu item to the active_admin page