Replace Bullet with Prosopite #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianPasquale
approved these changes
Jul 4, 2023
|
Can you update |
TimoPeraza
approved these changes
Jul 4, 2023
sebastiancaraballo
approved these changes
Jul 4, 2023
santib
commented
Jul 4, 2023
PerezIgnacio
approved these changes
Jul 4, 2023
juanmferreira93
approved these changes
Jul 5, 2023
claramaffei
approved these changes
Jul 5, 2023
santiagodiaz
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate replacing Bullet with Prosopite.
Remove
Bullet: Bullet has many false positives, causes a lot of headaches, doesn't work properly with Rails 7 (e.g. in some of our projects it's not detecting existing N+1s), the code is complex, and it's not well maintained.Add
Prosopite: It's like Bullet but its code is much simpler. We tested it in some of our projects and it worked well. Additionally, it's recommended by Nate Berkopec, who is an expert in these matters.Add
Rails' strict_loading: Rails 6.1 added this feature, which is good and useful for detecting N+1s, but it still has some limitations in its functionality that prevent us from using it instead of Prosopite. What we can start doing is using it to log N+1s (in all environments), and later on, if the feature continues to mature, it might be able to fully replace Prosopite.