-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to v4 #163
Merged
Merged
Merge master to v4 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update wrong host password error message * Fix unit test to look for the updated message * Get 100% code coverage
…ror (#145) * Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error * Add a clarifying comment and a new test case * Add two more test cases to get to 100% code coverage * Another test in pursuit of 100% * Remove optional chaining on catch. The error is always going to be set
* Support overriding various package upload form data * adds support for squashfs deployments --------- Co-authored-by: George Cook <[email protected]>
# Conflicts: # CHANGELOG.md # package-lock.json # package.json # src/RokuDeploy.spec.ts # src/RokuDeploy.ts # src/RokuDeployOptions.ts - deleteDevChannel call was added which changed order of sideload post requests - output file in makezip was changed to writefile
# Conflicts: # CHANGELOG.md # package-lock.json # package.json # src/RokuDeploy.spec.ts # src/RokuDeploy.ts # src/RokuDeployOptions.ts
TwitchBronBron
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging master, was tricky during the process so making a PR