Fix bug with absolute paths and getDestPath (#171)

* Fix bug with absolute paths and getDestPath * Fix bug in the test * remove .only
rokucommunity · Jul 19, 2024 · 2f90c39 · 2f90c39
1 parent 7091ae9
commit 2f90c39
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/src/RokuDeploy.spec.ts b/src/RokuDeploy.spec.ts
@@ -3018,6 +3018,19 @@ describe('index', () => {
     });
 
     describe('getDestPath', () => {
+        it('handles absolute paths properly', () => {
+            expect(
+                rokuDeploy.getDestPath(
+                    s`${tempDir}/rootDir/source/main.bs`,
+                    [{
+                        src: `${tempDir}/rootDir/source/main.bs`,
+                        dest: 'source/standalone.brs'
+                    }],
+                    `${tempDir}/src/lsp/standalone-project-1`
+                )
+            ).to.equal(s`source/standalone.brs`);
+        });
+
         it('handles unrelated exclusions properly', () => {
             expect(
                 rokuDeploy.getDestPath(

diff --git a/src/RokuDeploy.ts b/src/RokuDeploy.ts
@@ -228,13 +228,11 @@ export class RokuDeploy {
 
         function makeGlobAbsolute(pattern: string) {
             return path.resolve(
-                path.posix.join(
-                    rootDir,
-                    //remove leading exclamation point if pattern is negated
-                    pattern
-                    //coerce all slashes to forward
-                )
-            ).replace(/\\/g, '/');
+                rootDir,
+                //remove leading exclamation point if pattern is negated
+                pattern
+                //coerce all slashes to forward
+            ).replace(/\\+/g, '/');
         }
 
         let result: string;