Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand import@ before applying other transformations #34

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

expand import@ before applying other transformations #34

wants to merge 6 commits into from

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Apr 29, 2022 •
edited
Loading

Fix #18

The second commit fixes #33

The CI failure seems unrelated

@drzraf drzraf mentioned this pull request Apr 29, 2022
Open
mahagr
mahagr requested changes May 14, 2022
View reviewed changes
Copy link
Contributor

@mahagr mahagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick look, I found a few discussion points.

Blueprints/src/BlueprintForm.php Outdated Show resolved Hide resolved
Blueprints/src/BlueprintForm.php Outdated Show resolved Hide resolved
Blueprints/src/BlueprintForm.php Show resolved Hide resolved
Blueprints/src/BlueprintForm.php Outdated Show resolved Hide resolved
@drzraf
Copy link
Contributor Author

drzraf commented Sep 27, 2022

rebase on top of develop

@drzraf
Copy link
Contributor Author

drzraf commented Sep 27, 2022

1.4.7.txt

For the sake of my composer-patch, Grav installation: Patch adapted for 1.4.7 in attachment.

@drzraf drzraf requested a review from mahagr September 27, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahagr mahagr Awaiting requested review from mahagr

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'ordering@' => 0 does not work BlueprintForm: Make import@s to support ordering
3 participants
@drzraf @mahagr @rhukster