refactor: ✨ ruff rules enabled and fixed and code refactor made #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onuralp SEZER <[email protected]>
onuralpszr
added
bug
PreviewPreview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com. If commits are added to the pull request, synchronize your local branch:git pull origin formatting/ruff-rules
|
LinasKo
requested changes
Sep 19, 2024
onuralpszr
force-pushed
the
formatting/ruff-rules
branch
from
7da7927
to
9c4a07c
Compare
Signed-off-by: Onuralp SEZER <[email protected]>
onuralpszr
force-pushed
the
formatting/ruff-rules
branch
from
9c4a07c
to
a34f0e9
Compare
|
Thanks @onuralpszr! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added "ruff" formatting rule to be enabled (https://docs.astral.sh/ruff/rules/#ruff-specific-rules-ruf)
References
https://peps.python.org/pep-0448/
https://docs.astral.sh/ruff/rules/unnecessary-iterable-allocation-for-first-element/
https://docs.astral.sh/ruff/rules/mutable-class-default/