refactor(storage): use arc SstableInfo in HummockVersion #18573
+1,250
−730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwang28
force-pushed
the
wangzheng/arc_sstinfo
branch
3 times, most recently
from
062bcb2
to
365b2e4
Compare
zwang28
force-pushed
the
wangzheng/arc_sstinfo
branch
4 times, most recently
from
32f5534
to
852b9a7
Compare
zwang28
force-pushed
the
wangzheng/arc_sstinfo
branch
from
852b9a7
to
39a5b2e
Compare
wenym1
reviewed
Sep 19, 2024
| } | ||
|
|
||
| #[derive(Debug, PartialEq, Clone, Default)] | ||
| pub struct SstableInfoRef { |
There was a problem hiding this comment.
As we have implemented our own SstableInfo struct, can we just make the implementation of the clone of SstableInfo a shallow clone instead of explicitly introducing a struct wrapping it with arc? In this way, most of the changes in this PR can be avoided.
| } | ||
|
|
||
| task_local! { | ||
| pub static SSTABLE_INFO_CACHE: *mut SstableInfoCache; |
wenym1
reviewed
Sep 19, 2024
| pub type HummockVersionType = HummockVersionCommon<SstableInfoType>; | ||
| pub type HummockVersionDeltaType = HummockVersionDeltaCommon<SstableInfoType>; | ||
|
|
||
| pub trait SstableInfoReader { |
There was a problem hiding this comment.
Instead of implementing this trait, it's easier to use impl Deref<Target = SstableInfo>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Given that compute node now will retain many recent hummock versions, to reduce its memory footprint, this PR stores and reuses
Arc<SstableInfo>instead ofSstableInfoinHummockVersionfor compute node.Two major changes:
Arc<SstableInfo>andSstableInfo.SstableInfoCacheinHummockObserverNode, wherePbHummockVersionandPbHummockVersionDeltaare converted from to types, i.e.HummockVersion<Arc<SstableInfo>>.Arc<SstableInfo>is retrieved from the cache whenever feasible.Please find more details about how the
Arc<SstableInfo>is cached and shared inimpl From<&PbSstableInfo> for SstableInfoRefinsstable_info_ref.rs.This PR is part1 of the refactor, aiming to adapt the related methods to be compatible with bothArc<SstableInfo>andSstableInfo. After this PR, theHummockVersionin compute node will useArc<SstableInfo>. However theseArc<SstableInfo>is not reused acrossHummockVersion, i.e. the memory footprint is not reduced yet. It'll be done in another PR after this one.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.