fix: create sessions for empty app bundle identifiers

Closes #977
rime · Sep 9, 2024 · a30a6e9 · a30a6e9
1 parent 35d5acd
commit a30a6e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/action-install.sh b/action-install.sh
@@ -3,7 +3,7 @@
 set -e
 
 rime_version=latest
-rime_git_hash=2f89098
+rime_git_hash=24f0f7b
 sparkle_version=2.6.2
 
 rime_archive="rime-${rime_git_hash}-macOS-universal.tar.bz2"

diff --git a/sources/SquirrelInputController.swift b/sources/SquirrelInputController.swift
@@ -9,6 +9,7 @@ import InputMethodKit
 
 final class SquirrelInputController: IMKInputController {
   private static let keyRollOver = 50
+  private static var unknownAppCnt: UInt = 0
 
   private weak var client: IMKTextInput?
   private let rimeAPI: RimeApi_stdbool = rime_get_api_stdbool().pointee
@@ -332,7 +333,10 @@ private extension SquirrelInputController {
   }
 
   func createSession() {
-    guard let app = client?.bundleIdentifier() else { return }
+    let app = client?.bundleIdentifier() ?? {
+      SquirrelInputController.unknownAppCnt &+= 1
+      return "UnknownApp\(SquirrelInputController.unknownAppCnt)"
+    }()
     print("createSession: \(app)")
     currentApp = app
     session = rimeAPI.create_session()