Merge pull request #70 from reviewdog/sensible-exclude-default

Add sensible default value for exclude param
reviewdog · Jul 15, 2024 · 0e4ab9e · 0e4ab9e
2 parents c3f6296 + 4f61ed3
commit 0e4ab9e
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,7 +16,6 @@ jobs:
           file: testdata/testfile
           version_name: REVIEWDOG_VERSION
           repo: reviewdog/reviewdog
-
       - name: Check diff
         run: git diff
 
@@ -30,7 +29,6 @@ jobs:
           file: testdata/testfile
           version_name: REDPEN_VERSION
           repo: redpen-cc/redpen
-
       - name: Check diff
         run: git diff
 
@@ -44,7 +42,6 @@ jobs:
           file: testdata/testfile
           version_name: TMUX_VERSION
           repo: tmux/tmux
-
       - name: Check diff
         run: git diff
 
@@ -58,7 +55,6 @@ jobs:
           file: testdata/testfile
           version_name: POETRY_VERSION
           repo: python-poetry/poetry
-
       - name: Check diff
         run: git diff
 
@@ -73,7 +69,6 @@ jobs:
           version_name: THEMIS_VERSION
           repo: thinca/vim-themis
           tag: true
-
       - name: Check diff
         run: git diff
 
@@ -88,7 +83,6 @@ jobs:
           version_name: TERRAFORM_VERSION
           repo: hashicorp/terraform
           include: '^\d+\.\d+\.\d+$'
-
       - name: Check diff
         run: git diff
 
@@ -103,6 +97,32 @@ jobs:
           version_name: TERRAFORM_VERSION
           repo: hashicorp/terraform
           exclude: '-(alpha|beta|rc)'
+      - name: Check diff
+        run: git diff
 
+  exclude-default:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./
+        id: depup
+        with:
+          file: testdata/testfile
+          version_name: TERRAFORM_VERSION
+          repo: hashicorp/terraform
+      - name: Check diff
+        run: git diff
+
+  exclude-remove:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./
+        id: depup
+        with:
+          file: testdata/testfile
+          version_name: TERRAFORM_VERSION
+          repo: hashicorp/terraform
+          exclude: '' # empty
       - name: Check diff
         run: git diff
diff --git a/action.yml b/action.yml
@@ -23,6 +23,7 @@ inputs:
     required: false
   exclude:
     description: 'Regular expression not to use matched versions.'
+    default: '\b(rc|alpha|beta)(\b|\d+)'
     required: false
 outputs:
   current:

diff --git a/with-pr/action.yml b/with-pr/action.yml
@@ -23,6 +23,7 @@ inputs:
     required: false
   exclude:
     description: 'Regular expression not to use matched versions.'
+    default: '\b(rc|alpha|beta)(\b|\d+)'
     required: false
   tag_prefix:
     description: 'Tag prefix used for building link in PR description'