Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw instances of Error when unwrap, instead of plain objects #4215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pradiev
Copy link

@pradiev pradiev commented Feb 15, 2024

Currently, when unwrap any async action, library throws plain objects. This makes such errors hard to debug, especially when using errors collectors like sentry.

I think, using Error objects everywhere, the code throws any exceptions, is a must-have practice. Would be even better, if library include separate types inherited from Error based on the internal error type we already have as a field.

Copy link

codesandbox bot commented Feb 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 5ec2ebb
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/65ce582aa3e4590009dbfcad
😎 Deploy Preview https://deploy-preview-4215--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Feb 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ec2ebb:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@pradiev pradiev changed the title Throw instances of Errors when unwrap, instead of plain objects Throw instances of Error when unwrap, instead of plain objects Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant