Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lindex return code change for index is out of range. #2602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hwware
Copy link
Collaborator

@hwware hwware commented Nov 15, 2023

This request is to cover return value changes implemented as part of redis/redis#12769.

Copy link

netlify bot commented Nov 15, 2023

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3d660c5

@hwware hwware changed the title Lindex return code change for index is out of range #12769. Lindex return code change for index is out of range. Nov 15, 2023
@dwdougherty
Copy link
Collaborator

Hello Wen Hui. I'm one of the Redis technical writers. In this file on the main Redis source repo, there's the following definition:

      "reply_schema": {
           "oneOf": [
               {
                   "type": "null",
                   "description": "Index is out of range"
               },
               {
                   "description": "The requested element",
                   "type": "string"
               }
           ]
       },

If that reference is not correct, then it should also be amended.

@hwware
Copy link
Collaborator Author

hwware commented Nov 16, 2023

Thank you for reminding the details, I have updated the reply_schema in source repo as well. Please wait until redis/redis#11924 gets merged. so that there will not be any confusions.

Thank you.

@dwdougherty
Copy link
Collaborator

Thanks, Wen Hui. Looks like this is going into 8.0, so I'll wait until that's out to merge this PR.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants