Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordlist #2489

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Update wordlist #2489

merged 3 commits into from
Aug 7, 2023

Conversation

sav-norem
Copy link
Contributor

update wordlist to include commands for tabbed examples for lists and strings

update wordlist to include commands for tabbed examples for lists and strings
@netlify
Copy link

netlify bot commented Jul 18, 2023

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 19f8a12

@sav-norem
Copy link
Contributor Author

@dwdougherty could you review this?

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay, but I don't have experience with the spell checker. If you ran it by yourself, did everything look okay? If so, you're probably good.

@sav-norem
Copy link
Contributor Author

yea it works for me!

@dwdougherty
Copy link
Collaborator

That's great.

@dwdougherty
Copy link
Collaborator

Would you please also add the work "nx" to your PR? We saw that when working on committing your string PR.

@sav-norem
Copy link
Contributor Author

@dmaier-redislabs added the "nx" keyword - I'm hopeful if we can get this wordlist updated, the geospatial and list updates will be ready to go as well. sets data type is just about ready so I went ahead and added those shortcodes as well

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't require a local test build, but it should take care of the extant spellcheck issues.

@dmaier-redislabs dmaier-redislabs merged commit 6e23c64 into redis:master Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants