Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.md #2476

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Update strings.md #2476

merged 1 commit into from
Jul 19, 2023

Conversation

sav-norem
Copy link
Contributor

update strings datatype page to include hugo short codes for tabbed examples, removed "Let's play a bit with the string type, using redis-cli (all the examples will be performed via redis-cli in this tutorial)." as these examples will be in all the client languages

update strings datatype page to include hugo short codes for tabbed examples, removed "Let's play a bit with the string type, using redis-cli (all the examples will be performed via redis-cli in this tutorial)." as these examples will be in all the client languages
@netlify
Copy link

netlify bot commented Jul 7, 2023

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 147a9f6

@sav-norem
Copy link
Contributor Author

@elena-kolevska here's the string datatype page update - assuming David Dougherty should be involved but don't see his github as an account I can tag. Also a lot of the spell checks fail as the hugo short code names are things like setnx_xx

@elena-kolevska
Copy link
Contributor

Thanks Savannah. You can add the IDs to the wordlist file in order to force the checker to ignore them.

This is David"s hangle: @dwdougherty .

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look okay to me.

@dmaier-redislabs dmaier-redislabs merged commit 752d047 into redis:master Jul 19, 2023
1 check failed
@dmaier-redislabs
Copy link
Collaborator

This led to a failed build. We need to investigate it. @dwdougherty will fix it and send a new pull request for the fix.

@dwdougherty
Copy link
Collaborator

@dmaier-redislabs updated the version of Hugo on Netlify and the build now succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants