Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Amharic Translation #478

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

thezetrax
Copy link
Contributor

@thezetrax thezetrax commented Sep 22, 2022

Added Amharic (am) Translation

Summary by CodeRabbit

  • 新功能
    • 添加了对阿姆哈拉语(埃塞俄比亚)的本地化支持,确保应用程序能够以文化相关的方式展示日期、时间和导航提示。

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 9:17pm

src/locale/am.ts Outdated
import type { Locale } from '../interface';

const locale: Locale = {
locale: 'am',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

Suggested change
locale: 'am',
locale: 'am_ET,

@afc163
Copy link
Member

afc163 commented Jun 22, 2024

ping

@afc163
Copy link
Member

afc163 commented Aug 28, 2024

ping ~

Copy link

vercel bot commented Sep 1, 2024

@thezetrax is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Sep 1, 2024

Walkthrough

此次更改引入了阿姆哈拉语(埃塞俄比亚)的本地化配置。新文件 src/locale/am_ET.ts 定义了一个包含多种本地化字符串和格式选项的 locale 常量,确保应用程序能够以文化相关的方式呈现日期、时间和导航提示。

Changes

文件路径 更改摘要
src/locale/am_ET.ts 新增阿姆哈拉语本地化配置,定义 locale 常量并导出。

Sequence Diagram(s)

(此部分不适用)

Poem

在草地上蹦跶的小兔子,
新的语言如花儿绽放,
阿姆哈拉语,真美妙,
日期时间都明亮,
跳跃着欢庆这变化,
让我们一起欢唱! 🐇🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8f71ab1 and 6e58d39.

Files selected for processing (1)
  • src/locale/am_ET.ts (1 hunks)
Additional comments not posted (1)
src/locale/am_ET.ts (1)

1-33: 代码看起来不错!

这个文件导出了一个包含阿姆哈拉语翻译的 locale 对象,用于各种日期和时间相关的字符串。翻译看起来很完整,涵盖了与日期和时间选择及导航相关的广泛字符串。

代码结构良好,遵循了语言环境文件的预期格式。没有发现明显的问题或错误。

@thezetrax
Copy link
Contributor Author

@afc163 hi just updated the PR

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.42%. Comparing base (3b6df50) to head (e53a7b6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          64       64           
  Lines        2712     2712           
  Branches      754      759    +5     
=======================================
  Hits         2588     2588           
  Misses        121      121           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 changed the title Added Amharic Translation feat: Added Amharic Translation Sep 2, 2024
@afc163 afc163 merged commit 31a45f6 into react-component:master Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants