Skip to content

Commit

Permalink
Revert "tty/serial: pl011: restrict RX burst FIFO threshold"
Browse files Browse the repository at this point in the history
This reverts commit f3cb675.

Data loss has been observed on the Pi's PL011 UARTs since f3cb675 was
merged. The loss appears to be on reception, not transmission.

Revert the commit as a workaroud and potential fix.

Link: #6365
Link: #6144 (comment)
Link: https://forums.raspberrypi.com/viewtopic.php?t=376532

Signed-off-by: Phil Elwell <[email protected]>
  • Loading branch information
pelwell committed Sep 17, 2024
1 parent c132137 commit 8aa0ad8
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/tty/serial/amba-pl011.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,12 +487,6 @@ static void pl011_dma_probe(struct uart_amba_port *uap)
"RX DMA disabled - no residue processing\n");
return;
}
/*
* DMA controllers with smaller burst capabilities than 1/4
* the FIFO depth will leave more bytes than expected in the
* RX FIFO if mismatched.
*/
rx_conf.src_maxburst = min(caps.max_burst, rx_conf.src_maxburst);
}
dmaengine_slave_config(chan, &rx_conf);
uap->dmarx.chan = chan;
Expand Down

0 comments on commit 8aa0ad8

Please sign in to comment.