Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change bundle.js -> ramdaRepl.js; add authors to package.json #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buzzdecafe
Copy link
Member

A few changes:

  1. Rename bundle.* to ramdaRepl.* to avoid collisions;
  2. Add "contributors" field to package.json
  3. add build task to package.json that wraps up css, js, and minify steps

@craigdallimore
Copy link
Contributor

Sorry, only just saw this - it's been a wacky week. I'll take a look this evening 👍

@buzzdecafe
Copy link
Member Author

no worries, no rush.

@craigdallimore
Copy link
Contributor

This looks good to me.

I'm conscious that Try Ramda references bundle.js and bundle.css:

https://github.com/ramda/ramda.github.io/blob/master/repl/index.html#L56

I think we would want to simultaneously merge this and update Try Ramda at the same time to use the new filenames (I'm not sure how long the old ones will be available on the CDN). What do you think?

@buzzdecafe
Copy link
Member Author

sounds good to me, i will try to find some time to raise a pr on the docs repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants