Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changeset for publishing #35

Merged
merged 7 commits into from
Jul 31, 2023

Conversation

generall
Copy link
Member

This PR proposes to replace changeset publishing process with simple pnpm publish.

There are some reasons:

  • changeset have overcomplicated release process, which requires full knowledge of the tool even for simplest operations
  • changeset works unpredictably: instead on specifying concrete version number we want to release, changeset forces us to autoincrement versions. This operation is not idempotent and may create problems, for example, during the CI script problems (performing same operation twice does_not guarantee same result)
  • Unclear release strategy: same release script, depending on the obscure conditions, may launch a release or create a commit in some other branch (?)

This PR is WIP as publishing CI pipeline was not tested

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

⚠️ No Changeset found

Latest commit: 85c6458

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rendez
Copy link
Collaborator

Rendez commented Jun 23, 2023

The release.yml workflow dispatched on tags means anything pushed to master won't run any pipeline, if tags are created off master to issue a release, maybe master should also have a pipeline where we run similar checks as in the pull request workflow, i.e.:

      - name: Project checks
        run: pnpm -r pre-check

      - name: Integration tests
        run: packages/qdrant-js/scripts/integration-tests.sh
        shell: bash

@IvanPleshkov IvanPleshkov force-pushed the remove-changeset-for-publishing branch from fa54402 to 01faeee Compare July 31, 2023 15:01
@IvanPleshkov
Copy link
Contributor

The release.yml workflow dispatched on tags means anything pushed to master won't run any pipeline, if tags are created off master to issue a release, maybe master should also have a pipeline where we run similar checks as in the pull request workflow, i.e.:

      - name: Project checks
        run: pnpm -r pre-check

      - name: Integration tests
        run: packages/qdrant-js/scripts/integration-tests.sh
        shell: bash

There are cases when pushing to master should not call any release pipeline. An example of such changes is this PR with CI changes =) We don't want to release something after pushing this PR.
Also, release by tags is comfortable for rust team because of a similar approach for each client (Python, Go, Rust ect). Similar release steps between clients are more comfortable that perfect CI for each client separately.

@IvanPleshkov
Copy link
Contributor

Removed OpenAPI similarity check from CI. There are some cases where we won't check the latest QDrant openapi. This PR is an example of this situation. v1.4.0 is coming but this PR is based on v1.3.0. And we cannot merge this PR. Also, we don't want to merge v1.4.0 first because it will trigger changeset, unresolvable situation.
If someone doubt it, create please separate PR with restoring this check. In such PR grpc protofiles checks are expected too

@IvanPleshkov IvanPleshkov changed the title WIP: Remove changeset for publishing Remove changeset for publishing Jul 31, 2023
@IvanPleshkov IvanPleshkov merged commit c6f1214 into master Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants