-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove changeset for publishing #35
Conversation
|
The release.yml workflow dispatched on tags means anything pushed to - name: Project checks
run: pnpm -r pre-check
- name: Integration tests
run: packages/qdrant-js/scripts/integration-tests.sh
shell: bash |
fa54402
to
01faeee
Compare
There are cases when pushing to master should not call any release pipeline. An example of such changes is this PR with CI changes =) We don't want to release something after pushing this PR. |
Removed OpenAPI similarity check from CI. There are some cases where we won't check the latest QDrant openapi. This PR is an example of this situation. v1.4.0 is coming but this PR is based on v1.3.0. And we cannot merge this PR. Also, we don't want to merge v1.4.0 first because it will trigger changeset, unresolvable situation. |
This PR proposes to replace
changeset
publishing process with simplepnpm publish
.There are some reasons:
changeset
have overcomplicated release process, which requires full knowledge of the tool even for simplest operationschangeset
works unpredictably: instead on specifying concrete version number we want to release,changeset
forces us to autoincrement versions. This operation is not idempotent and may create problems, for example, during the CI script problems (performing same operation twice does_not guarantee same result)This PR is WIP as publishing CI pipeline was not tested