105 Add "module_acceptance_custom.yml" which allows for more flexible use cases. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for validity, it is tested in the field with migration of module https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration , with success. |
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
69d673b
to
e982609
Compare
|
FYI, I have my own tests running against my own forked version. https://github.com/sooyean-hoo/cat-github-actions/blob/dev_sooyean/.github/workflows/module_acceptance_custom.yml This is where all the results above come from . |
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
e982609
to
566e31e
Compare
generated by matrix_from_metadata_v2 Add new custom workflow Add in a new input: matrix_from_metadata default to matrix_from_metadata_v2 Clean up some spaces in *custom.yaml Signed-off-by: Hoo Sooyean (何書淵) <[email protected]> Fix a mistake of the task name
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
566e31e
to
26d60a2
Compare
sooyean-hoo
changed the title
sooyean-hoo
changed the title
sooyean-hoo
changed the title
sooyean-hoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing problem or issue in #105 .
For .github/workflows/module_acceptance.yml, can we have a version which does not hardcoded to all the Litmus Tasks? This makes it harder to update some of old modules, whose dependencies/implementation/styles vary a lot.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
#105
#103 - This included as also for continuity, as it is also on the same theme and for the same approach.
Checklist