Remove hardcoded version of ruby and puppet and replaced with values #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generated by matrix_from_metadata_v2
sooyean-hoo
force-pushed
the
103-runner-shows-not-contain-hard-coded-values-it-should-be-derived-from-configuration-files
branch
from
aeb0bb3
to
488c7e3
Compare
Ramesh7
reviewed
Sep 6, 2024
| @@ -30,6 +30,8 @@ jobs: | |||
| runs-on: ${{ inputs.runs_on }} | |||
| outputs: | |||
| acceptance_matrix: ${{ steps.get-matrix.outputs.matrix }} | |||
| ruby_version: ${{ steps.get-puppet_ruby_version.outputs.ruby_version }} | |||
There was a problem hiding this comment.
Not have much understanding about github actions so would like to know how we are going to get the ruby and puppet version?
is it via env variables or some other way?
Also I see ruby version is still hardcoded here https://github.com/puppetlabs/cat-github-actions/pull/104/files#diff-5fce77d76af8d0d3fa602998f1421a39b77dbe8d832a45718f521b729e1fb43fR47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use values generated by matrix_from_metadata_v2
Summary
Replace Line 45 and 70 of https://github.com/puppetlabs/cat-github-actions/blob/b98f1f160644f6e81b14df7fda190dc2bd8b62a3/.github/workflows/module_acceptance.yml which are hardcoded. There are also some additional support line code, along with the changes.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Runner should not contain hard-coded values, it should be derived from configuration files. #103
Checklist