Use Pulumi Base Image instead of Python #115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieMcKinstry
added
impact/performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the Kitchen Sink image to be
FROMthe Pulumi base image instead of Debian.As is, I'm not sure this will actually speed up image caching, since the base image doesn't contain much of anything -- it installs Pulumi, but as written, this PR requires the Kitchen Sink to reinstall pulumi using the provided version build-arg. I'm going to see if I can use the build-arg in the
FROMclause to dynamically specify the base, allowing us to skip the installation steps already conducted by the base.Closes #114