Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip update checks for bundled packages #91

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Skip update checks for bundled packages #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e5e217
Skip update checks for bundled packages
confused-Techie Sep 8, 2023
29b64b6
Add spec for new behavior
confused-Techie Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions spec/upgrade-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,23 @@ describe('apm upgrade', () => {
});
});

it('does not display updates for "core" packages', () => {
fs.writeFileSync(path.join(packagesDir, 'core-package', 'package.json'), JSON.stringify({
name: 'core-package',
version: '1.0',
repository: 'https://github.com/pulsar-edit/pulsar'
}));
const callback = jasmine.createSpy('callback');
apm.run(['upgrade', '--list', '--no-color'], callback);

waitsFor('waiting for upgrade to complete', 600000, () => callback.callCount > 0);

runs(() => {
expect(console.log).toHaveBeenCalled();
expect(console.log.argsForCall[1][0]).toContain('empty');
});
});

it('does not display updates for packages whose engine does not satisfy the installed Atom version', () => {
fs.writeFileSync(path.join(packagesDir, 'test-module', 'package.json'), JSON.stringify({
name: 'test-module',
Expand Down
6 changes: 6 additions & 0 deletions src/upgrade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ available updates.\
}

getLatestVersion(pack, callback) {
// We want to bail on checking for updates of any packages that come with the editor
// This can generally be detected by checking if the repository is that of Pulsar itself
if (pack.repository === "https://github.com/pulsar-edit/pulsar") {
return callback();
}

const requestSettings = {
url: `${config.getAtomPackagesUrl()}/${pack.name}`,
json: true
Expand Down