Added Data Dragon for TFT #245
Conversation
There was a problem hiding this comment.
In addition to other review comments, should add integration tests for these changes. See league ddragon integration tests for an example.
Overall, everything looks good, just small changes needed to merge.
| @@ -1,3 +1,4 @@ | |||
| from .LeagueApi import LeagueApi | |||
| from .MatchApi import MatchApi | |||
| from .SummonerApi import SummonerApi | |||
| from .DataDragonApi import DataDragonApi | |||
There was a problem hiding this comment.
nit: add newline at end of file
| tacticians = DDragonVersionLocaleEndpoint("/tft-tactician.json") | ||
| traits = DDragonVersionLocaleEndpoint("/tft-trait.json") | ||
| versions = DataDragonEndpoint("/realms/{region}.json") | ||
| versions_all = DataDragonEndpoint("/api/versions.json") |
There was a problem hiding this comment.
nit: add newline at end of file
| @@ -0,0 +1,14 @@ | |||
| from ...league_of_legends.urls.DataDragonUrls import DataDragonEndpoint, DDragonVersionLocaleEndpoint | |||
There was a problem hiding this comment.
dont import things from league APIs in TFT; copy+pasting classes is preferable here so that the games are not mixed up in any way
|
|
||
| from riotwatcher._apis.team_fight_tactics import DataDragonApi | ||
|
|
||
| @pytest.mark.lol |
There was a problem hiding this comment.
this should be @pytest.mark.tft
| mock_base_api = MagicMock() | ||
| expected_return = object() | ||
| mock_base_api.raw_request_static.return_value = expected_return | ||
|
|
||
| static_data = DataDragonApi(mock_base_api) | ||
|
|
||
| version = "234" | ||
| locale = "sdfasdf" | ||
|
|
||
| ret = static_data.arenas(version, locale) | ||
|
|
||
| mock_base_api.raw_request_static.assert_called_once_with( | ||
| f"https://ddragon.leagueoflegends.com/cdn/{version}/data/{locale}/tft-arena.json", | ||
| {}, | ||
| ) |
There was a problem hiding this comment.
optional because legacy issues:
there is a more elegant way to not repeat this code in each function using a text fixture instead. See league matchv5 unit tests for an example.
|
FYI CI failures appear to be either my fault or the codecov actions fault. I will look into that |
Added Data Dragon Endpoint for TFT assets. Passed tox tests on python 3.10.
P.S. first ever contribution, please let me know if I need to do any other test or something.