Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration testing #269

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

limarkxx
Copy link
Contributor

Adds integration testing, with a sample multi-root workspace

@limarkxx limarkxx mentioned this pull request Jul 27, 2023
@tm1000
Copy link
Collaborator

tm1000 commented Jul 27, 2023

ooooooooo!

@tm1000
Copy link
Collaborator

tm1000 commented Jul 27, 2023

I love laravel as much as the next person (I daily drive it) but I wonder if adding Laravel here adds too much bloat to this extension's git repo. Shouldnt we test this extension against some base PHP files instead?

Same applies with Slim or others.

@limarkxx
Copy link
Contributor Author

Maybe but it should at least be something at least slightly challenging for psalm to munch on.
Perhaps put those files in https://github.com/psalm/sample-laravel-app and https://github.com/psalm/sample-slim-webapp, and use git submodules to bring them in as necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants