696 Prefetch the Advertising Info #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialization tests with and without the adId initialization step and the runs are the same, there is performance hinderance.
...e/PrebidMobile-core/src/main/java/org/prebid/mobile/rendering/utils/helpers/AdIdManager.java
Outdated
Show resolved
Hide resolved
...idMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/rendering/sdk/SdkInitializer.java
Show resolved
Hide resolved
...e/PrebidMobile-core/src/main/java/org/prebid/mobile/rendering/utils/helpers/AdIdManager.java
Show resolved
Hide resolved
YuriyVelichkoPI
requested changes
Jun 21, 2024
...le-core/src/main/java/org/prebid/mobile/rendering/networking/modelcontrollers/Requester.java
Outdated
Show resolved
Hide resolved
...e/PrebidMobile-core/src/main/java/org/prebid/mobile/rendering/utils/helpers/AdIdManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
@ValentinPostindustria please take a look at the task and implementation.
In general, the goal makes perfect sense. It will help to speed up requests. However, it is very hard to follow the implementation design. Too much tasks, listners and states. I'm afraid to introduce some new bugs related to the memory leaking or blocking.
So we need to be sure that everything works as expected. And If someone see the more simple implementation approach - it would be great to consider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #696