Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve globe key supports #3917

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

tekezo
Copy link
Member

@tekezo tekezo commented Aug 31, 2024

TODO

  • Add the keyboard type setting wizard.
  • Improve the detection method of Karabiner virtual devices.

Changes

  • Update Karabiner-DriverKit-VirtualHIDDevice (v5.0.0)
  • When using a custom Vendor ID and Product ID on the virtual keyboard, there was an issue where fn + control + arrows (the window tiling shortcut in Sequoia) was not handled properly by macOS. Therefore, the Vendor ID and Product ID were changed to use the same values as Apple's keyboard.
  • When using Apple's Vendor ID and Product ID, the keyboard type is automatically selected based on the Product ID. Therefore, the mechanism that linked the country_code with the keyboard type on the virtual keyboard has been removed.
  • The implicit behavior of changing fn + arrows to home, end, page_up, and page_down has been removed. This is because fn + arrows sent from keyboards with Apple's Vendor ID and Product ID are properly handled by macOS without requiring any conversion.
  • The operation_type::set_keyboard_type has been removed.
  • The country_code support has been removed from configuration_json_helper.
  • Updated core_configuration/virtual_hid_keyboard:
    • Added keyboard_type_v2.
    • Removed country_code and strict_fn_arrows.
  • Updated manipulator_environment:
    • Removed system_preferences_properties and virtual_hid_keyboard_keyboard_type from manipulator_environment.
    • Changed core_configuration_ type from weak_ptr to shared_ptr.

@tekezo tekezo changed the title Improve globe key supports [WIP] Improve globe key supports Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant