Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onvista Example for JSON API Import of historical data #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Bravehartk2
Copy link

This is my first PR for this project.
Hence I use Portfolio Performance very often and like it very much (THANKS!) and because I really had problems to find a data source for stock quotation, I thought, this would be a good opportunity to contribute a little to this project .

What I did:

  • Add .idea folder to gitignore, for all who want to edit the markdown in Intellij IDE (PHPStorm etc.)
  • Added a example for a JSON based import via Onvista API to the JSON How To (Datenimport via API)

English version will be added, if the German version is ok so far.

Marcel Lange added 3 commits August 3, 2024 13:50
…n in Intellij IDE (PHPStorm etc.)

- Added a example for a JSON based import via Onvista API to the JSON How To (Datenimport via API)
@Sn1kk3r5 Sn1kk3r5 self-requested a review August 6, 2024 09:03
@Sn1kk3r5
Copy link
Collaborator

Sn1kk3r5 commented Aug 6, 2024

Hi @Bravehartk2,

danke für deinen PR. Ich schau ihn mir die Tage an. Ich bin gerade etwas unter Wasser.

Evtl. könntest Du mit der englischen Version noch warten oder ggf. schon einmal mit @hug-sch sprechen (Englisch)

Danke und viele Grüße

@Bravehartk2
Copy link
Author

Bravehartk2 commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants