Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label_id and floor_id to action.target object #1511

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

hellow554
Copy link
Contributor

@hellow554 hellow554 commented Aug 21, 2024

Description

Add the label_id to the action.target object

Related Issue

This PR fixes or closes issue: fixes #1510, fixes #1427

Motivation and Context

Allow it to add the label_id via the graphical editor

How Has This Been Tested

I did npm run build, then pushed it to my live HA instance, reloaded the browser and it worked ;)

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@hellow554
Copy link
Contributor Author

One thing that must be elabortaed is, whether the two other occurences must be adopted as well.
See #1510 (comment)

Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. I will also add the fix to Home Assistant front-end for official cards.

You can also add labels: string[] to EntityRegistryDisplayEntry as you mentioned in your common. It will not be used for now but at least the type will be the right one.

EDIT: it can be done later in another PR.

@piitaya piitaya changed the title add label_id to action.target object Add label_id and floor_id to action.target object Aug 21, 2024
@piitaya piitaya merged commit 75af465 into piitaya:main Aug 21, 2024
1 check passed
@piitaya piitaya added the bug Something isn't working label Aug 21, 2024
@hellow554 hellow554 deleted the action.target branch August 21, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants