Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cover-card): allow custom actions for control buttons #1089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndreasBieber
Copy link

Description

Added options for overriden actions from cover control buttons

Related Issue

#891

This PR fixes or closes issue: fixes #891

Motivation and Context

#891

How Has This Been Tested

To test the new feature, I started a HASS demo instance as well as the mushroom dist server. The new feature was then tested and verified in the UI with various actions.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya
Copy link
Owner

piitaya commented Mar 29, 2023

I think we should have a generic way to define list of actions instead of adding it to cover card. Why cover card and not light, alarm and vacuum card ?

@AndreasBieber
Copy link
Author

AndreasBieber commented Mar 29, 2023

Great idea @piitaya . Unfortunately I'm not that deep in the Typescript/HASS Extensions topic to implement this. Maybe you can explain what you have in mind, then I can tackle this in a further PR.

But until then you could merge this PR first, so that the functionality is basically there. Your idea would probably result in a breaking change, right?

@AndreasBieber
Copy link
Author

@piitaya Any chance to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Mushroom Cover Card - Allow custom action for control buttons
2 participants