Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to php-parser v5 #1124

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Upgrade to php-parser v5 #1124

merged 1 commit into from
Feb 9, 2024

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Feb 9, 2024

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? kinda yes, kinda no
Deprecations? yes
Documented? yes
Fixed tickets #1119
Shim phpro/grumphp-shim#28

Upgrades php-parser to v5.
New configuration:

php_version

Default: null

Can be any PHP version specified as major.minor. For example: 8.2.
There is a special placeholder latest, which will use the latest supported PHP version from php-parser.
If left empty, the system's PHP version will be picked. This is the default behaviour.

The old kind option got deprecated and will be removed in grumphp v3.
Since the option lets you select PHP5 or 7, I don't think this will actually be a BC break in grumphp 2 (which requires at least PHP 8.1 anyways). In case it was set, it will be ignored and the system's default PHP version will be selected.

I won't be tagging a new major for this, because I believe the changes are very subtle: for most people they won't be an issue and overcomeable for people with very high customizations.

@veewee veewee merged commit 970d082 into phpro:v2.x Feb 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant