Merge pull request #1145 from wucdbm/patch-1

Support --skip-property-types of ValidateSchemaCommand
phpro · Jul 11, 2024 · b3986f0 · b3986f0
2 parents a265d52 + 4ce0156
commit b3986f0
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/doc/tasks/doctrine_orm.md b/doc/tasks/doctrine_orm.md
@@ -10,6 +10,7 @@ grumphp:
         doctrine_orm:
             skip_mapping: false
             skip_sync: false
+            skip_property_types: false
             triggered_by: ['php', 'xml', 'yml']
 ```
 
@@ -25,6 +26,12 @@ With this parameter you can skip the mapping validation check.
 
 With this parameter you can skip checking if the mapping is in sync with the database.
 
+**skip_property_types**
+
+*Default: false*
+
+With this parameter you can skip checking if Entity field property types match the Doctrine types.
+
 **triggered_by**
 
 *Default: [php, xml, yml]*

diff --git a/src/Task/DoctrineOrm.php b/src/Task/DoctrineOrm.php
@@ -24,6 +24,7 @@ public static function getConfigurableOptions(): ConfigOptionsResolver
         $resolver->setDefaults([
             'skip_mapping' => false,
             'skip_sync' => false,
+            'skip_property_types' => false,
             'triggered_by' => ['php', 'xml', 'yml'],
         ]);
 
@@ -58,6 +59,7 @@ public function run(ContextInterface $context): TaskResultInterface
         $arguments->add('orm:validate-schema');
         $arguments->addOptionalArgument('--skip-mapping', $config['skip_mapping']);
         $arguments->addOptionalArgument('--skip-sync', $config['skip_sync']);
+        $arguments->addOptionalArgument('--skip-property-types', $config['skip_property_types']);
 
         $process = $this->processBuilder->buildProcess($arguments);
 

diff --git a/test/Unit/Task/DoctrineOrmTest.php b/test/Unit/Task/DoctrineOrmTest.php
@@ -25,6 +25,7 @@ public function provideConfigurableOptions(): iterable
         yield 'defaults' => [
             [],
             [
+                'skip_property_types' => false,
                 'skip_mapping' => false,
                 'skip_sync' => false,
                 'triggered_by' => ['php', 'xml', 'yml'],
@@ -120,5 +121,16 @@ public function provideExternalTaskRuns(): iterable
                 '--skip-sync',
             ]
         ];
+        yield 'skip-property-types' => [
+            [
+                'skip_property_types' => true,
+            ],
+            $this->mockContext(RunContext::class, ['hello.php', 'hello2.php']),
+            'doctrine',
+            [
+                'orm:validate-schema',
+                '--skip-property-types',
+            ]
+        ];
     }
 }