replace magic __toString method with toString #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4veI
commented
Apr 13, 2021
| @@ -308,7 +308,7 @@ public function withFragment($fragment); | |||
| * - If an authority is present, it MUST be prefixed by "//". | |||
| * - The path can be concatenated without delimiters. But there are two | |||
| * cases where the path has to be adjusted to make the URI reference | |||
| * valid as PHP does not allow to throw an exception in __toString(): | |||
| * valid: | |||
There was a problem hiding this comment.
wondering if throwing exceptions for these cases would be an option now..
|
👎 Newer PHP does allow this method to throw an exception. |
👎 |
|
What about adding the method then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if we've replaced the magic __toString method with a regular toString method, would make the usage nicer.