Fix: Add ETS buffering for telemetry events in TelemetryListener #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 16, 2024
| @@ -95,6 +111,9 @@ defmodule Phoenix.LiveDashboard.TelemetryListener do | |||
| :telemetry.detach({__MODULE__, event, self()}) | |||
| end | |||
|
|
|||
| # Clean up ETS table | |||
| :ets.delete(:dashboard_telemetry) | |||
There was a problem hiding this comment.
There is no need to delete it, the table is automatically GCed if the process terminates.
|
Thank you for the PR but I am confused. We never read from the table. How does this help with buffering? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of high event rates in the Phoenix Live Dashboard by introducing an ETS-based buffering system in
TelemetryListener. It ensures that events are buffered efficiently and prevents system overload by trimming the buffer when necessary.Key changes:
These updates ensure the metrics page continues to function smoothly even under high telemetry event loads.