Fix CoreComponents margin between inputs and labels
#5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor issue with the input component from the
core_components.exfile (used in phx.gen.live)A margin top is added by default on inputs for the spacing between the label and the input.
However it is not removed if a label is not provided. Which causes alignment issue when combining the input component with other elements.
As suggested by José Valim, putting the margin on the label itself is more appropriate.
Changes
attrto thelabelcomponentmt-2from inputs inCoreComponentsmb-2tolabelwithinputCloses #5832