Ignore digested assets

[almirsarajcic]

Currently, some digested assets aren't ignored by either git or Docker: favicon, robots.txt file, images, fonts, etc. Basically, only digested CSS and JS are. People testing (prod) releases locally are affected by this issue.

I couldn't find a better solution than relying on the format of the digested filename (hash is 32 characters long) and the extension of the Gzip archive. I've used this for years in one of the projects I'm working on.

To reproduce, generate a new Phoenix app, then run mix assets.deploy.

Before:

➜  infra_check git:(main) mix assets.deploy

Rebuilding...

Done in 240ms.

  ../priv/static/assets/app.js  109.8kb

⚡ Done in 10ms
Check your digested files at "priv/static"
➜  infra_check git:(main) ✗ git status
On branch main
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        priv/static/favicon-91f37b602a111216f1eef3aa337ad763.ico
        priv/static/images/logo-06a11be1f2cdde2c851763d00bdd2e80.svg
        priv/static/images/logo-06a11be1f2cdde2c851763d00bdd2e80.svg.gz
        priv/static/images/logo.svg.gz
        priv/static/robots-9e2c81b0855bbff2baa8371bc4a78186.txt
        priv/static/robots-9e2c81b0855bbff2baa8371bc4a78186.txt.gz
        priv/static/robots.txt.gz

nothing added to commit but untracked files present (use "git add" to track)

After:

➜  infra_check git:(ignore-digested-assets) mix assets.deploy

Rebuilding...

Done in 234ms.

  ../priv/static/assets/app.js  109.8kb

⚡ Done in 9ms
Check your digested files at "priv/static"
➜  infra_check git:(ignore-digested-assets) git status
On branch ignore-digested-assets
nothing to commit, working tree clean

[josevalim]

Thanks for the PR. However I am worried about false positives here, especially if someone adds an external .gz extension. Given digest usually happens inside a Dockerfile or in a build server, I'd prefer to not add this change to avoid other surprises.

[almirsarajcic]

Makes sense. I'll just continue using this in my project templates.