Add support for static resources with fragments. Closes #5507 #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypconstante
reviewed
Jul 11, 2023
lib/phoenix/endpoint.ex
Outdated
|
|
||
| defp path_and_fragment(path_incl_fragment) do | ||
| path_incl_fragment | ||
| |> String.split("#") |
There was a problem hiding this comment.
An SVG can contain a number sign in it's id, for example ~p"/images/icons.svg#warning#small".
Suggested change
| |> String.split("#") | |
| |> String.split("#", parts: 2) |
phoebe100
force-pushed
the
5507_support_static_resource_with_fragment
branch
2 times, most recently
from
d490a08
to
7a9ffff
Compare
phoebe100
force-pushed
the
5507_support_static_resource_with_fragment
branch
from
7a9ffff
to
a4fad82
Compare
|
Thank you so much! ❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, you can use the ~p sigil to resolve static assets with fragment identifiers (e.g. useful to address only a specific section of an SVG image).
For instance, if you have a "digest" version of an asset:
Before:
Now:
Closes #5507