Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some warnings when MSVC warning level is 4 #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Demonese
Copy link

image

@Demonese
Copy link
Author

Demonese commented Aug 21, 2022

Test build system:
CMakeLists.txt

cmake_minimum_required(VERSION 3.24)
project(qoi)

add_library(libqoi)
if(MSVC)
    target_compile_options(libqoi PRIVATE
        "/utf-8"
        "/W4"
    )
else()
    target_compile_options(libqoi PRIVATE
        "-Wall"
        "-Wextra"
        "-Wpedantic"
        "-Werror"
    )
endif()
if(WIN32)
    target_compile_definitions(libqoi PRIVATE
        _CRT_SECURE_NO_WARNINGS
    )
endif()
set_target_properties(libqoi PROPERTIES
    C_STANDARD 17
    C_STANDARD_REQUIRED ON
)
target_compile_definitions(libqoi PRIVATE
    QOI_IMPLEMENTATION
)
target_include_directories(libqoi PUBLIC
    .
)
target_sources(libqoi PRIVATE
    qoi.h
    qoi.c
)

qoi.c

#ifndef QOI_IMPLEMENTATION
#define QOI_IMPLEMENTATION
#endif
#include "qoi.h"

run = 0;
}
}
else {
int index_pos;

if (run > 0) {
bytes[p++] = QOI_OP_RUN | (run - 1);
bytes[p++] = QOI_OP_RUN | (unsigned char)(run - 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not declaring run as an unsigned char ?

run = 0;
}

index_pos = QOI_COLOR_HASH(px) % 64;

if (index[index_pos].v == px.v) {
bytes[p++] = QOI_OP_INDEX | index_pos;
bytes[p++] = QOI_OP_INDEX | (unsigned char)index_pos;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as run above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants