Add count #2458
Draft
Add count #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally prefer tests before time. |
fflaten
reviewed
May 18, 2024
| @@ -728,7 +728,7 @@ function Get-WriteScreenPlugin ($Verbosity) { | |||
| throw "Unsupported level of output '$($PesterPreference.Output.Verbosity.Value)'" | |||
| } | |||
|
|
|||
| $humanTime = "$(Get-HumanTime ($_test.Duration)) ($(Get-HumanTime $_test.UserDuration)|$(Get-HumanTime $_test.FrameworkDuration))" | |||
| $humanTime = Get-HumanTime $_test.Duration | |||
There was a problem hiding this comment.
Also affects Detailed++. Intentional?
There was a problem hiding this comment.
intentional, but will revert.
|
Good idea with |
|
I'd prefer parentheses on the first element as it helps separate filename from details at a glance, especially without colored output (plaintext/colorblind/etc) Don't have a strong opinion on whether it should contain testcount or duration. I guessed you felt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both approaches look pretty ugly, ideas?
Fix #2434