Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify feature model name #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/flip/declarable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ def feature(key, options = {})
end

# Adds a strategy for determining feature status.
def strategy(strategy)
FeatureSet.instance.add_strategy strategy
def strategy(strategy, model_klass = nil)
FeatureSet.instance.add_strategy strategy, model_klass
end

# The default response, boolean or a Proc to be called.
Expand Down
10 changes: 8 additions & 2 deletions lib/flip/feature_set.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,14 @@ def << definition
end

# Adds a strategy for determing feature status.
def add_strategy(strategy)
strategy = strategy.new if strategy.is_a? Class
def add_strategy(strategy, model_klass = nil)
if strategy.is_a? Class
if model_klass && model_klass.is_a?(Class)
strategy = strategy.new model_klass
else
strategy = strategy.new
end
end
@strategies[strategy.name] = strategy
end

Expand Down