Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle empty client_secret with basic and post client auth #610

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix: handle empty client_secret with basic and post client auth #610

merged 3 commits into from
Jul 6, 2023

Conversation

Exidex
Copy link
Contributor

@Exidex Exidex commented Jul 6, 2023

Implementation of #609

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 6, 2023
View reviewed changes
test/client/client_instance.test.js Dismissed Show dismissed Hide dismissed
@panva panva changed the title Support setting client_secret to an empty string when using client_secret_basic or client_secret_post fix: handle empty client_secret with basic and post client auth Jul 6, 2023
@panva panva merged commit 402c711 into panva:main Jul 6, 2023
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Exidex @panva