Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common stale action #1

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Add common stale action #1

merged 1 commit into from
Sep 6, 2023

Conversation

thozza
Copy link
Member

@thozza thozza commented Sep 6, 2023

Also update README.

Also update README.

Signed-off-by: Tomáš Hozza <[email protected]>
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I like this. I'm curious how the reset works when the label is removed or a comment is made. Does the 30 day countdown begin again?

@ondrejbudai
Copy link
Member

I think the workflow needs a schedule. Otherwise, this this perfect.

@ondrejbudai
Copy link
Member

Oh, this is just a composite action, it needs to be enabled per repo, I see.

Cannot we just have central copy of this workflow, so we don't need to add it to every repo?

@thozza
Copy link
Member Author

thozza commented Sep 6, 2023

Oh, this is just a composite action, it needs to be enabled per repo, I see.

The intention of this repo is to have the action configured in a single place and then enable it in each repo where we want it... I'm open to suggestions if you know of a better way.

Cannot we just have central copy of this workflow, so we don't need to add it to every repo?

From what I checked, the only option to have it in every repo where we want to use it. There is no such thing as organization-wide actions, or something similar.

I can probably create a scheduled workflow in this repo, which could be then copied over to other repos, but that's about it. I'm also not sure if we want to use Schutzbot's GH token or let GitHub create new action-specific token on each run. since the action calls GH API where rate limiting applies. So using a single bot token could probably make us hit the rate limit more easily... 🤔

@thozza
Copy link
Member Author

thozza commented Sep 6, 2023

Good idea. I like this. I'm curious how the reset works when the label is removed or a comment is made. Does the 30 day countdown begin again?

Yes, it should be as you described... More information is available at https://github.com/actions/stale

@ondrejbudai
Copy link
Member

FTR, having the action handle other repositories is not yet possible, see: actions/stale#1081

Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for proposing this!

@achilleas-k achilleas-k self-requested a review September 6, 2023 13:05
@thozza thozza merged commit 7a21e00 into osbuild:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants