Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create an interface for status console #1481

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Create a interface for console so that alternate implementations can exist. In doing this, I found the Size() method was not properly implemented, so I created a GetHeightWidth() method.

Partial: #1461

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (5792c35) to head (76ba908).

Files Patch % Lines
...md/oras/internal/display/status/console/console.go 81.81% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   85.54%   85.50%   -0.04%     
==========================================
  Files         113      113              
  Lines        3936     3940       +4     
==========================================
+ Hits         3367     3369       +2     
  Misses        342      342              
- Partials      227      229       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TerryHowe TerryHowe force-pushed the refactor-console branch 2 times, most recently from 41f5867 to 4af9db7 Compare August 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant