Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify track reader manager and messenger use #1474

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

If we just pass the messenger to reader, it will be a lot easier to test these packages.

Partial: #1461

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 82.40741% with 19 lines in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (5792c35) to head (6d7282d).

Files Patch % Lines
...md/oras/internal/display/status/console/discard.go 80.00% 6 Missing ⚠️
...md/oras/internal/display/status/console/console.go 83.33% 2 Missing and 2 partials ⚠️
cmd/oras/internal/display/status/track/target.go 69.23% 2 Missing and 2 partials ⚠️
cmd/oras/root/blob/fetch.go 62.50% 2 Missing and 1 partial ⚠️
cmd/oras/root/blob/push.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
- Coverage   85.54%   85.42%   -0.12%     
==========================================
  Files         113      114       +1     
  Lines        3936     3986      +50     
==========================================
+ Hits         3367     3405      +38     
- Misses        342      350       +8     
- Partials      227      231       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TerryHowe TerryHowe force-pushed the progress-manager branch 9 times, most recently from b7b0a9a to d2ffbe7 Compare August 16, 2024 21:06
@TerryHowe TerryHowe marked this pull request as draft August 19, 2024 18:10
@TerryHowe
Copy link
Member Author

I'm going to make a couple PRs out of this until it is focused only one the reader/messenger refactor again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant