Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup StableHLO bytecode patches used for temporary pjrt compatibility #2420

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

GleasonK
Copy link
Member

@GleasonK GleasonK commented Jul 1, 2024

Several hacks/patches were put in place to preserve StableHLO compatibility for PJRT plugins.

Recently PJRT was switched to send VHLO, meaning we can clean up all these patch fixes.

Closes #2216

Copy link
Member

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Can we also close #2216 since we are getting rid of the patch diff?

@GleasonK GleasonK merged commit 8eb0ad3 into openxla:main Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up GenericDenseArrayAttr after properties migration
2 participants