-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legalize quantized stablehlo operation using uniform_quantize/uniform_dequantize #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdasgup3
force-pushed
the
quant-to-int-unary-ops
branch
2 times, most recently
from
June 14, 2024 22:00
bafe8e3
to
7afb5a5
Compare
sdasgup3
force-pushed
the
quant-to-int-unary-ops
branch
from
June 15, 2024 01:34
85e418a
to
b47c342
Compare
GleasonK
reviewed
Jun 17, 2024
GleasonK
reviewed
Jun 17, 2024
GleasonK
reviewed
Jun 17, 2024
GleasonK
reviewed
Jun 17, 2024
sdasgup3
force-pushed
the
quant-to-int-unary-ops
branch
from
June 17, 2024 19:21
b47c342
to
54cf0d1
Compare
GleasonK
requested changes
Jun 17, 2024
GleasonK
reviewed
Jun 17, 2024
sdasgup3
force-pushed
the
quant-to-int-unary-ops
branch
4 times, most recently
from
June 18, 2024 01:31
1035a48
to
76aaa36
Compare
quanwanandy
approved these changes
Jun 18, 2024
sdasgup3
force-pushed
the
quant-to-int-unary-ops
branch
from
June 18, 2024 16:47
76aaa36
to
171e893
Compare
GleasonK
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides with a pass to decompose StableHLO quantized programs using uniform quantize/dequantize
operations. For example, the following program
Per the docs/spec.md, following is the exhaustive list of ops which can be interpreted
using dq-op-q
strategy. The current PR handles all these ops except for un-bolded ones (DotGeneralOp
,ConvolutionOp
,DynamicConvOp
, andAddOp
) which are already lowered to integer match using--stablehlo-legalize-quant-to-int
pass.